Promote connection_tracking_policy field in google_compute_region_backend_service from beta to GA#17396
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 239b8c0: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportImportant Manual Verification Required (GA-only additions) The following tests are GA-only additions and cannot be run by VCR in Beta mode. Please verify them manually: 🔴 TestAccComputeRegionBackendService_regionBackendServiceConnectionTrackingExample Analytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the build log or the debug logs folder for detailed results. @xingyazhao, @BBBmau VCR tests complete for 239b8c0! |
| tracking_mode = "PER_SESSION" | ||
| connection_persistence_on_unhealthy_backends = "NEVER_PERSIST" | ||
| idle_timeout_sec = 60 | ||
| enable_strong_affinity = true |
There was a problem hiding this comment.
i wouldn't expect a value in a test config to be changed on a promotion to GA PR. is there a reason behind this?
There was a problem hiding this comment.
enable_strong_affinity field is currently in the folder list phase, and this test with v1 API will return a 400 error if this field is set to true. The field's status is also mentioned in the public API doc (This option is not available publicly).
BBBmau
left a comment
BBBmau
left a comment
There was a problem hiding this comment.
LGTM! the Beta -> GA test returns passing when running in TeamCity Build Run
3 participants
This change promotes the
connection_tracking_policyfield ingoogle_compute_region_backend_serviceresource from beta to GA. This allows users to configure connection tracking policy for regional backend services in the google provider.The corresponding acceptance test is also updated to test it in the google provider.